Great STart
October 26, 2007 - 20:28 — andremolnar
Hey folks,
Just wanted to drop by and let you know that this module is a great start.
Just noticed a couple of things, and will likely open tickets on the drupal project page after I have had a chance to make sure they are real issues.
1) postalcode search api docs say that only one of postalcode or location are required. But the code checks to see that both have been entered.
2) there are an awful lot of calls to module_invoke_all during a single request. I think there is room for optimizing this.
All in all - great stuff.
andre
- Login to post comments
1) Please provide some more
1) Please provide some more information -- I just tested http://geonames.edesign.no/examples/postalcodesearch and it seems to be working like intended independently of each other (at least for a search on location "Oslo" or postal code 0855.... Are you using the latest version from drupal.org? There have been a few updates..
You could check if your local docs match the docs here, as they are automatically generated from the service definition files...
2) I know about this issue, and will add it to the todo list... It just turned out this way because I only intended to write support for a couple of services, but suddenly ended up defining them all ;) Everything could really just be included in one big file, it isn't that much data -- but I guess it's a few hours work to rewrite it.
E